Name of container should be checked first#594
Open
umermala wants to merge 3 commits intojesseduffield:masterfrom
Open
Name of container should be checked first#594umermala wants to merge 3 commits intojesseduffield:masterfrom
umermala wants to merge 3 commits intojesseduffield:masterfrom
Conversation
hamzanajeebkhan
approved these changes
Nov 19, 2024
jesseduffield
requested changes
Dec 22, 2024
Author
|
@jesseduffield Can you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In most of the cases, the base image is used without making any changes and name label is not provided however, in most use cases, name is provided therefore the Name key should be checked first and then label name and if none is given then just default name